search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Unnecessary Files #322

Closed cemalgnlts closed 6 months ago

cemalgnlts commented 6 months ago

Hi,

When I built my project in the latest version, I realized that there were files that did not exist before.

For example, a markdown file is being added: Screenshot 2024-01-20 12 50 59

Diagnostics JSON files: Screenshot 2024-01-20 12 52 49

And I'm not sure where this icon is used: Screenshot 2024-01-20 12 55 32

CGNonofr commented 6 months ago

Yes, in the last version, the build process of extensions has been changed to stop filtering extension files that should be bundled. It was a hazardeous process that became even harder after the last change minimizing extension codes.

Is that an issue for you? The only consequence I see is the build time maybe a little longer and the bundled size a little bigger, but those files won't get loaded in the client

cemalgnlts commented 6 months ago

Is that an issue for you?

Not, really.

CGNonofr commented 6 months ago

Useless files from extension without code should not be bundled anymore with the last version