CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Rework CI, stop synchronizing with VSCode versions #326

Closed CGNonofr closed 5 months ago

CGNonofr commented 6 months ago

based on https://github.com/CodinGame/monaco-vscode-api/pull/327

fix #291

dkattan commented 6 months ago

This is very exciting. I've always felt like the treemending approach particularly the postinstall hook was very brittle and this appears to clean a lot of that up. Love the work you are doing here!

CGNonofr commented 6 months ago

This is very exciting. I've always felt like the treemending approach particularly the postinstall hook was very brittle and this appears to clean a lot of that up. Love the work you are doing here!

Thank you for your kind words and your feedback :)

CGNonofr commented 6 months ago

I've always felt like the treemending approach particularly the postinstall hook was very brittle and this appears to clean a lot of that up.

Me too!

btw, there was already an alternative to the postinstall hook: the monaco-editor-treemended package

CGNonofr commented 5 months ago

@kaisalmen we need this PR to release a v2, otherwise it will just release a 1.85.7

kaisalmen commented 5 months ago

@CGNonofr is it ready? It is a Draft currently. 😉

CGNonofr commented 5 months ago

@CGNonofr is it ready? It is a Draft currently. 😉

my bad :laughing: it's ready now (:

CGNonofr commented 5 months ago

I can't really judge if this is working or not as I don't have the means to fully test it. Please go ahead. The released artifacts are working as expected, thought.

Note that we can now release a next version using the github CI directly, and I've used it to release the version you're testing. The differences between the main and next channels are handled by semantic-release itself so it's probably quite safe

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kaisalmen commented 5 months ago

@CGNonofr There is a problem. v2.0.0 does not carry the latest tag: image

CGNonofr commented 5 months ago

@CGNonofr There is a problem. v2.0.0 does not carry the latest tag: image

Oh no :cry: