CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Improve modularity #336

Closed CGNonofr closed 5 months ago

CGNonofr commented 5 months ago

This PR removes the include and exclude query param when importing VSCode module that allowed us to import only partially a module. It has some downside:

Replaced by simply splitting the file by hands using the patch file

This PR aims at removing unwanted visible commands (in the command picker) when the view service override is not used

There are still some remainings but I don't think will be able to perfectly split them without introducing a huge complexity

CGNonofr commented 5 months ago

@CompuIves or @kaisalmen will you have some time anytime soon to have a look at it? it's quite blocking for me

CGNonofr commented 5 months ago

This PR makes sense. There's also a downside to using the patch file, though. We need to keep the new files in sync, and make sure that when we update we check that those files are still in sync with VSCode equivalent.

That said, I think those separate files is the lesser of the two evils, it's better than having ?include. I was bitten before by that as well.

I am looking for a better approach than having a big PATCH file... relying on a fork with several additional commit and rebasing it at every VSCode release seems like a better idea but I don't know how to implement it exactly

Thanks btw!

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 2.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: