search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

Update to VSCode 1.87 #361

Closed CGNonofr closed 7 months ago

CGNonofr commented 7 months ago

and some other fixes and improvements I've noticed while upgrading

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kaisalmen commented 7 months ago

@CGNonofr independent of the example I always get this error with 3.0.0: image

kaisalmen commented 7 months ago

@CGNonofr I also see that hasUpdatedDefaultThemes does not exist. This is related to trying to load original workers when using monaco-editor in classic mode (see #363): image

CGNonofr commented 7 months ago

@CGNonofr independent of the example I always get this error with 3.0.0: image

It really looks like you have multiple versions of the extension service override

@CGNonofr I also see that hasUpdatedDefaultThemes does not exist. This is related to trying to load original workers when using monaco-editor in classic mode (see #363): image

What you are trying seems a little hazardeous, let's talk about it on the linked issue

kaisalmen commented 7 months ago

It really looks like you have multiple versions of the extension service override

I did not add anything and I just checked that @codingame/monaco-vscode-extensions-service-override is really imported nowhere.

CGNonofr commented 7 months ago

It really looks like you have multiple versions of the extension service override

I did not add anything and I just checked that @codingame/monaco-vscode-extensions-service-override is really imported nowhere.

You're right, found the issue!