CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
208 stars 29 forks source link

Improve patch management #366

Closed CGNonofr closed 4 months ago

CGNonofr commented 4 months ago

@kaisalmen I'd really like to know what you think about this change regarding patches, do you think it's enough?

kaisalmen commented 4 months ago

what you think about this change regarding patches, do you think it's enough?

It is clearer what is happening. Was there a specific motivation for changing it?

CGNonofr commented 4 months ago

what you think about this change regarding patches, do you think it's enough?

It is clearer what is happening. Was there a specific motivation for changing it?

I wanted to improve it for a long time, there are more and more stuff on the patch and having everything mixed up in a big patch make it hard to maintain and to know why a specific change was made

kaisalmen commented 4 months ago

Will you trigger a new release once #365 and #366 are merged?

CGNonofr commented 4 months ago

Will you trigger a new release once #365 and #366 are merged?

Sure ! Already running !

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

CompuIves commented 3 months ago

I love this change!