search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
208 stars 29 forks source link

Missing `initialize` from `vscode/extensions` in "^v1.83.15" causes error in monaco-languageclient "^6.6.1" #372

Closed kfreezen closed 3 months ago

kfreezen commented 3 months ago

This issue has been raised once, in #283, however, it seems that monaco-languageclient 6.6.1 depends on initialize being defined in vscode/extensions

Could a shim be added back in to keep compatibility with monaco-languageclient ^6.6.1?

Thanks! Or perhaps there is another workaround to be used that you might suggest.

kfreezen commented 3 months ago

I'd like to add that I am aware this is an out of date version, but I'm working on bringing an old piece of code using Monaco / monaco-languageclient from the Stone Age to something more modern, and this would be quite helpful, if not to me, then to others facing the same issue.

In the meantime I will work around by pinning to v1.83.14 in my project dependencies.

CGNonofr commented 3 months ago

This library api gets more and more stable over time and you are referring to a time when it was often changing. And we were releasing every version as a patch version...

It should not happen in the future but I don't think we'll be able to do anything regarding old versions

kfreezen commented 3 months ago

Thanks for the response. I'll close this issue. Hopefully this workaround saves someone else a few hours of time.

kfreezen commented 3 months ago

Workaround in package.json

{
  "dependencies": {
    "vscode": "npm:@codingame/monaco-vscode-api@==1.83.14",
   }
}