CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

Update monaco-editor-webpack-plugin descripton with regard to languages #378

Closed kaisalmen closed 6 months ago

kaisalmen commented 6 months ago

This updates the languages bullet in the monaco-editor-webpack-plugin section. I also applied some markdown formatting recommendation. Do you want to mention the monaco-languages somewhere else/some other section?

kaisalmen commented 6 months ago

@CGNonofr Does it make sense to exchange build and lint? My commit message was not well-formed

CGNonofr commented 6 months ago

@CGNonofr Does it make sense to exchange build and lint? My commit message was not well-formed

You mean to change the order? what would it change? aren't they done in // ?

kaisalmen commented 6 months ago

what would it change?

Build takes 16 min. Lint only some seconds. It would fail fast. That's all. 🙂

CGNonofr commented 6 months ago

what would it change?

Build takes 16 min. Lint only some seconds. It would fail fast. That's all. 🙂

I'm not sure to understand, you are talking about commitlint, right?

kaisalmen commented 6 months ago

I'm not sure to understand, you are talking about commitlint, right?

It's Monday. Nevermind, It is already where it should be. I just checked the actions instructions-

CGNonofr commented 6 months ago

Thanks!

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 3.2.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: