search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
208 stars 29 forks source link

Use official ext host server #380

Closed CGNonofr closed 3 months ago

CGNonofr commented 3 months ago

There is no point of building the server when Microsoft already does it for us

It allows to simplifies the build process but also simplifies the usage in a docker environment: you don't need node or npm, the VSCode server is a standalone

CompuIves commented 3 months ago

Oh, this will simplify the build process for us as well!

CGNonofr commented 3 months ago

Oh, this will simplify the build process for us as well!

Can you elaborate?

CompuIves commented 3 months ago

Can you elaborate?

I'm working on VSCode Server support in CodeSandbox, and we have a build step where we build vscode server and tar it, so the server can download it. We need to build VSCode server with an old version of Node, though, because our current environment has a glibc version that's too high. Also, we need to ship standalone Node to our VMs. So this would remove both steps (building in Docker, and shipping standalone Node ourselves).

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 3.2.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kaisalmen commented 3 months ago

@CGNonofr nice work. Was mostly AFK over extended easter weekend.