search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
208 stars 29 forks source link

Update to VSCode 1.88 #384

Closed CGNonofr closed 3 months ago

kaisalmen commented 3 months ago

@CGNonofr oh there is an error in the demo build. The signature of TestRun changed It seems addCoverage should now be used.

CGNonofr commented 3 months ago

@CGNonofr oh there is an error in the demo build. The signature of TestRun changed It seems addCoverage should now be used.

Indeed! it's fixed :)

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kaisalmen commented 3 months ago

@CGNonofr in monaco-languageclient with the new packages and no code changes I see this problem: image

CGNonofr commented 3 months ago

@CGNonofr in monaco-languageclient with the new packages and no code changes I see this problem: image

Well spotted! fixed by the last commit of https://github.com/CodinGame/monaco-vscode-api/pull/385

kaisalmen commented 3 months ago

Well spotted!

Thanks, just approved the PR.