search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
208 stars 29 forks source link

Fix localization issues second attempt #387

Closed CGNonofr closed 3 months ago

kaisalmen commented 3 months ago

@CGNonofr awesome, when do you sleep? I have one further request: Can you export interfaces AvailableLanguage and LocalizationOptions from @codingame/monaco-vscode-localization-service-override because this is part of the exposed getServiceOverride, but one can't import the type. I externalized the "default" function and it is nicer if it can have a specific type. Thank you.

CGNonofr commented 3 months ago

@CGNonofr awesome, when do you sleep? I have one further request: Can you export interfaces AvailableLanguage and LocalizationOptions from @codingame/monaco-vscode-localization-service-override because this is part of the exposed getServiceOverride, but one can't import the type. I externalized the "default" function and it is nicer if it can have a specific type. Thank you.

sure! 87a8fa6e987ae8a01240a01ff20d21f7e4434866

(sorry for the delay, I was sleeping!)

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 4.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: