search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

Update to VSCode 1.90 #445

Closed CGNonofr closed 3 months ago

kaisalmen commented 3 months ago

@CGNonofr I tested it locally and everything seems fine, but you broke the demo build

kaisalmen commented 3 months ago

I will give you a go once that is fixed.

kaisalmen commented 3 months ago

@CGNonofr I just read this in the VSCode release notes: image

Does it mean you can/should move to node 20 here as well?

CGNonofr commented 3 months ago

@CGNonofr I just read this in the VSCode release notes: image

Does it mean you can/should move to node 20 here as well?

AFAIK, They seem to be still using node 18 for building though, but I've switched to last versions and everything seems to work so... updated

CGNonofr commented 3 months ago

@CGNonofr I just read this in the VSCode release notes: image Does it mean you can/should move to node 20 here as well?

AFAIK, They seem to be still using node 18 for building though, but I've switched to last versions and everything seems to work so... updated

Hum nop, doesn't work, rollbacked

kaisalmen commented 3 months ago

Hum nop, doesn't work, rollbacked

ok, VSCode not having aligned build and execution env sounds fishy. On the other hand the SW stack involved is deep and broad regarding dependencies.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 6.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: