CodinGlitch / SimpleRadio

This mod is a plugin of Simple Voice Chat which adds radio communication over frequencies you can use to communicate with your friends while far away!
GNU General Public License v3.0
21 stars 9 forks source link

Terrible server performance #35

Open restonic4 opened 3 months ago

restonic4 commented 3 months ago

If you place some mics and then you leave those chunks, the moment the server unloads the chunks it start lagging so bad.

I used spark to see what was causing the issue, and I found this:

imagen_2024-06-12_214028737

Using Fabric, 1.20.1

If i place a chunk loader next to the microphone it fixes the problem, so thats something to do with the chunk having the mic being unloaded.

restonic4 commented 3 months ago

I made a video showing how to reproduce it, and it crashed the entire server at the end.

Video: https://www.youtube.com/watch?v=fDJW35GGckk

The server crashed without a crashlog.

It only happens on good servers (5gb ram + & 3 cpu cores +)

Tested on a modded server and a vanilla server with vc and vc radios (Both servers lags)

restonic4 commented 3 months ago

I think this is the method/mixin image

CodinGlitch commented 3 months ago

thanks for the very detailed report! ill look into what the root of the problem could be and i'll get back to you if i have any details

CodinGlitch commented 3 months ago

i wasn't able to replicate the issue to the same degree as the video, but i made some changes in 2.3.5 that might fix the issue, so further testing is needed for this one

restonic4 commented 3 months ago

Ok, i will try testing it a little bit more and documenting it.