search

Coding-Coach / find-a-mentor-api

CodginCoach API
35 stars 37 forks source link

Set availability for mentors #121

Closed crysfel closed 4 years ago

crysfel commented 4 years ago

As a mentor I want to set my availability, so I can hide my profile from the mentor search results.

closes #118

brentmclark commented 4 years ago

Code looks good to me, but I can't shake the feeling that excluding unavailable mentors from the mentors list is cutting too deep. Maybe in the UI you could continue to show the unavailable mentors, but replace the connections section with some copy that says, for example, this mentor has marked themselves unavailable.

crysfel commented 4 years ago

@brentmclark @arku Thank you so much for your review! I've implemented the updates

crysfel commented 4 years ago

Code looks good to me, but I can't shake the feeling that excluding unavailable mentors from the mentors list is cutting too deep. Maybe in the UI you could continue to show the unavailable mentors, but replace the connections section with some copy that says, for example, this mentor has marked themselves unavailable.

Yes! I like this idea, I will update the code to return the mentors but with available=false so the UI can take those out