search

Coding-Coach / find-a-mentor

The Coding Coach mentors website
https://mentors.codingcoach.io
MIT License
738 stars 427 forks source link

Adding Formik to Register/Login page #833

Open isiakaabd opened 3 years ago

isiakaabd commented 3 years ago

Is your feature request related to a problem? Please describe.

The signup/login page only have HTML validation.(the required attribute,)

Describe the solution you'd like

with Formik, more aesthetic, validation and functionality to the form

moshfeu commented 3 years ago

Hi, thank you for the feedback! I'm not familiar with Formik but from a very quick look it looks awesome!

Have said that, the login / register forms are generated and actually hosted in auth0 - our authentication provider so we don't have much control of it.

Auth0 gives the ability to make our own login / register page but since it does work, I believe we should put our limited resources (developers) on things we don't have at all.

What do you think?

BTW, we have more forms, it would be an interesting experiment to switch them to Formik or other React form library. Would you want to explore this?

isiakaabd commented 3 years ago

Thanks for the response Moshfeu, The current UI is awesome,my thought was having the signup/login button inactive when no email/password is enter, so a user don't bother at all on clicking it, also it helps to format the UI and things like password strength and the likes can be displayed.

I would love to explore other forms that react formik can be used. I will further search the repo and a direction will be appreciated.

Thanks