Coding-Enthusiast / FinderOuter

Easy to use bitcoin recovery tool to fix damaged private key, mini-private key, address, BIP38 encrypted key, mnemonic (seed phrase), BIP-32 derivation path, Armory backups, recover passwords and more
MIT License
283 stars 107 forks source link

Missing base58 WIF chars at unknown place.Example 8/12 not working,BIP38 password limitation,no Stop button,Missing WIF chars limit #82

Open CryptoXploit opened 2 months ago

CryptoXploit commented 2 months ago

Hello to the author, 1.you have not tested the features fully.in Missing base58 section, you have mentioned that WIF upto 3 chars missing at unknown position can be recovered without using regex expressions. Example number 8/12 is not working and giving error "The given key has an invalid checksum." 2.Under "Missing base58" .in Advanced(limit search space).if there are 10 or more chars missing in WIF then we have to add manually same text again and again 10 or more times. Its not a feasible feature. If someone needs to repeat same set of missing chars. there should be button "Add to all missing chars".it will make search fast and less time consuming. 3.there is start button "Find!" but there must be a stop button as well.one has to close the program and add every information again and again. 4.in "Missing base58" if the compressed WIF is missing 11 chars then it can scan and find proper key within seconds but if the missing chars are 12 or more then the tool don't even start scanning. For example puzzle #64 **KwDiBf89QgGbjEhKnhXJuH7LrciVrZi3qZ6FxoaD5***** .it will find within second but if it is KwDiBf89QgGbjEhKnhXJuH7LrciVrZi3qZ6FxoaD**** then the tool wont even start scanning. Is that a bug or limitation on missing key chars? 5.the Bip38 encrypted key password recovery is limited up to 6 chars even if we want to test the password using a passlist text file which contains 170 password & the password is "P@ssw0rd"(for testing purpose).it is giving error "Password is too long (bigger than SHA256 block size)."

Test systems running windows 11 latest- 1.AMD EPYC dual processors 128 cores/256 Threads with 512 GB RAM 2.Intel XEON processor 48 cores/96 threads with 256 GB RAM 3.FinderOuter V 0.19.1.0

fix the error and re-test the tool. thank you very much.

Coding-Enthusiast commented 1 month ago

Hello and thanks for your feedback.

  1. After adding the SearchSpace option, this feature was disabled
    https://github.com/Coding-Enthusiast/FinderOuter/commit/0e66f6e2cd5b5483763b9acd1c96c208ff4072b8#diff-53ca38a010e48324cc9ccc6dac05df12b1e118054ff23a4565eb570a8b092938R1253-R1254 I'll have to add it as a separate recovery option.
  2. If each position needs to go through all 58 characters, there is no need to touch the "Advanced" section at all to manually enter the chars since they are filled automatically. SearchSpace option is for when you want to limit the characters. However, I'll try to add a "copy list" option to ease that process (eg. copy an entered list from position 2, then paste it for position 5).
  3. It is in my todo list...
  4. It's a limit. The missing chars from end method is an optimization that only works when the checksum is the missing part or the bigger part of what's missing. With 12 missing chars in a compressed WIF, the bigger part that's missing is the key itself and the number of permutations that have to be checked shoots up to over 1.3 billion and cannot be solved within reasonable time. You can see this exponential growth here: https://github.com/Coding-Enthusiast/FinderOuter/blob/4cbaaeb70e31b80830fe85af32708fddee72ac26/Src/FinderOuter/Services/Base58Service.cs#L104-L113
  5. That error message sounds like a bug that I have to investigate further.
Coding-Enthusiast commented 1 month ago
  1. Fixed in 6397494417a374ffb870bca91423634b68456194
  2. Fixed in f9a2cb2a466b906cc0b5b22fd21a953cc45d5a2d