search

CodingAleCR / http_interceptor

A lightweight, simple plugin that allows you to intercept request and response objects and modify them if desired.
MIT License
133 stars 68 forks source link

Allow 'maxRetryAttempts' to be flexible according to response status #143

Open ayyysh04 opened 8 months ago

ayyysh04 commented 8 months ago

Is your feature request related to a problem? Please describe. If a programmer wants to retry 3 times in case of '400' status error and 1 time in case of '401' error ,he will not be able to do so due to restriction of current 'maxRetryAttempts' method

Describe the solution you'd like Will be adding a 'response' as argument to 'maxRetryAttempts' method ,so that programmer can decide the retry count according to response status

Describe alternatives you've considered Above solution will work

Additional context [NONE]

ayyysh04 commented 8 months ago

@CodingAleCR if aligned ,kindly assign this ticket to me and merge the PR as asap.Currently our app uses interceptor beta version ,but not able to adopt this use case

CodingAleCR commented 7 months ago

I'll take a closer look, but it does seem to align with the purposes of the package. Thank you for contributing!

CodingAleCR commented 5 months ago

@all-contributors add @ayyysh04 for ideas

allcontributors[bot] commented 5 months ago

@CodingAleCR

I've put up a pull request to add @ayyysh04! :tada: