Closed Mawi137 closed 3 years ago
Hi, thanks for the PR, it is awesome that you catch this flaw. Would you mind making a test for it? This is just so future releases will also check for this when adding or improving features.
Took me a while to figure out why it was only sending the last param for each key though 😅
I added a test as requested. Sorry for the weird commit message, I pressed enter instead of backspace and it was too late 😄
Thanks a lot, I'm checking out a few other details, but it's looking good. I will probably send a patch release with your changes. Thanks a lot for contributing :)
@all-contributors add @Mawi137 for tests and code
@CodingAleCR
I've put up a pull request to add @Mawi137! :tada:
When passing params with a list as value, it will only add the last item of that list as a param when using
url.queryParameters
. WithqueryParametersAll
it will keep that list. Each item of that list will then be added as a query param.