search

CodingAleCR / http_interceptor

A lightweight, simple plugin that allows you to intercept request and response objects and modify them if desired.
MIT License
134 stars 67 forks source link

Missing parameters for DELETE method #89

Closed MaciejZuk closed 3 years ago

MaciejZuk commented 3 years ago

Hello,

I have found one problem with DELETE method.

Intercepted_client.dart - line 144

@override Future delete( Uri url, { Map<String, String>? headers, Object? body, Encoding? encoding, }) => _sendUnstreamed( method: Method.DELETE, url: url, headers: headers, );

You have missed pass two parameters (body and encoding) for method _sendUnstreamed inside delete method.

Could you please correct it?

CodingAleCR commented 3 years ago

Hi, thank you so much for the effort you put into this, I'll fix it as soon as possible! 🤓

CodingAleCR commented 3 years ago

Once #90 is merged and a release is done, this should be fixed for you. @all-contributors add @MaciejZuk for bugs

allcontributors[bot] commented 3 years ago

@CodingAleCR

I've put up a pull request to add @MaciejZuk! :tada: