Updated font awesome icons on dashboard

CodingForProduct / tap_rewards

Coding-for-Product Mentorship Project - Demo Transit System Reward App

MIT License

3 stars 2 forks source link

Updated font awesome icons on dashboard #71

Closed LfifteenA closed 7 years ago

LfifteenA commented 7 years ago

I only updated the font-awesome icons on the dashboard but for some reason, I can see that in this change, git changed the file path to the layouts adding a "public" to the path (e.g. views/layouts/layout.ejs → public/views/layouts/layout.ejs). @tinuola I know you had a similar experience with the css initially being in a "public" folder - and not working. Think this will this cause the same css file mapping errors?

carolinambravo commented 7 years ago

@lisa sorry I made a similar change in the pull request I just made. I don't understand why it's changing the name of your files. One idea -- did you by chance move the "views" folder into the "public" folder. On my current version these are at the same level in the folder hierarchy but it seems it is renaming these files as if "views" is now within "public" in your branch.

LfifteenA commented 7 years ago

Per comment above - going to close pull request and delete the branch. Don't want such a minor update to cascade into larger errors after we finally got the app deployed and working