Using a modal to show the video instead of embedding all the videos

CodingGarden / listd

listd is a Full Stack App that will allow users to create, share and watch lists of YouTube channels. This app is being built LIVE on Twitch https://twitch.tv/codinggarden

https://twitch.tv/codinggarden

MIT License

191 stars 53 forks source link

Using a modal to show the video instead of embedding all the videos #106

Closed omar2205 closed 1 year ago

omar2205 commented 1 year ago

Describe the problem

Currently, we embed all the iframes, and the player is small.

Describe the proposed solution

User click the video and it opens a modal to 1) embed the iframe 2) play the video

Have you checked if this issue has already been raised?

[X] I did not find any similar issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

vishalbalaji commented 1 year ago

Alternatively, I would suggest a Theater Mode toggle, which just causes the iframe to resize to the full width of the screen.

w3cj commented 1 year ago

Going with theater mode / full screen video.