search

CodingGarden / listd

listd is a Full Stack App that will allow users to create, share and watch lists of YouTube channels. This app is being built LIVE on Twitch https://twitch.tv/codinggarden
https://twitch.tv/codinggarden
MIT License
193 stars 53 forks source link

Added only render YouTubeVideoEmbed in the view port #127

Open albertlast opened 1 year ago

albertlast commented 1 year ago

reduce the load time massiv depends of the amount video released by the channels

What type of Pull Request is this?

What is the current behavior?

Load all images/stuff of all videos of all channels in the list -> result massiv load/cpu time

What is the new behavior?

Just rendering the most relevant videos, when scrolling down more get loaded (since they are near the view port)

Other information

add dependency svelte-inview

i try to keep pr small/focused, so i didn't added a default height/width --> the scroll bar is "jumping" when scrolling down

also the option for svelte-inview could maybe optimize

albertlast commented 1 year ago

test can't run since the project doesn't want package-lock.json be part of a pr, but since i added new dependcy test can't run.