Open CassandraGoose opened 5 years ago
Submitted this for review! Please let me know if this description will suffice and I will start working. Thanks a ton!
Hey @CassandraGoose This looks good overall. The only thing I would update is the How will users interact with your web site?
section.
Part of the requirements are that there is a landing page with a description of your app, and then the user can click a button to go to the app (search page in your example). https://github.com/CodingGarden/seedling-school-01-frontend-project#what-you-will-build
Update that section and then you can get started on wireframing and coding!
Thanks a ton - Updated! I will get started now.
Update: Here are my wireframes (super basic):
Looking good! Thanks for sharing. This will definitely help others when they start their project. Feel free to post screen shots of your app as you build it as well!
Another update - turns out that the developer version of the API I am using only gives snippets of the articles instead of the whole article. To work around this, I'm going to have a 'Read more' at the end of each snippet that links to the original article (which is provided by the API).
Always good to dig deep into your API before committing to using it or be prepared to do some work-arounds.
First page scaffolded:
Second page scaffold + initial JS:
Looks great!!
Hey! I have completed my features -> I would LOVE LOVE LOVE to steal a code review and a UI/UX review. No rush. Thanks much, friend!
Great work overall!! Code review up next!
main.html
index.js
formatDate
function is a bit redundant. Can reduce the code to just:
dateP.textContent = new Date().toDateString();
main.js
nonBannedArticles
function might be re-named to removeBannedArticles
or filteredArticles
const nonBannedArticles = (articles) => {
const bannedRegexp = new RegExp(bannedWords.join('|'), 'ig');
return articles.filter((article) => {
return !article.title.match(bannedRegexp);
});
};
addArticlesToPage
function, you can use the content element you created, instead of selecting at the bottom of the function.If you have the time, watch the video to see more feedback not listed here. Also, take a look at the checklists I created in this repo.
Updates have been made - thanks for going through everything!
Project Name / Title
Non-Earthling News
Your Name / Title
Project Description
Get the latest news about our friends from outer space, sourced from all over the web. With easy sorting, filtering and searchability, you will be able to find all the latest alien information you desire.
What 3rd Party Web API do you plan to use?
Which of the following describes you: