CodingTrain / AStar

AStar example with community contributions
117 stars 66 forks source link

Fix/Refactor of neighbor array populating (issue #18) #19

Closed ootsby closed 7 years ago

ootsby commented 7 years ago

I tacked on a fix for application of the visual heuristic and removed an unnecessary (AFAICT) loop calling addNeighbors in the BSP mapgen.

Hyftar commented 7 years ago

Try squashing your last commit when fixing an existing commit instead of adding another commit. In this case this should be fairly straightforward; Just follow this tutorial.

Once you're done, just do a forced update using git push origin master -f (assuming origin is the name of your forked repo).

I think keeping (or at least striving to keep) a clean git history is quite important.

ootsby commented 7 years ago

Thanks for the pointer. However, as far as I'm aware, the recipient has the option to squash a PR when they take it if they wish. Alternatively they can bounce it if there are issues with the automatic process and request a squash then.

shiffman commented 7 years ago

Thanks for this!