Adding Sound Effects - Githubissues

shiffman commented 3 months ago

Starting on #81. This is a proof of concepts, currently includes:

A "thinking" sound
A "typing" sound

Open to ideas for other sounds and sound effects! Possible additional features

Sound loops during a given state and then cuts off or fades out when next state begins
Button to enable / disable sound effects
Button for me to trigger specific sound effects like the "challenge bell"

@supercrafter100 @dipamsen I wonder if we want some kind of more proper "state" manager that knows what state bot is in and all things follow from that (message to animator, sound effects, etc.)

supercrafter100 commented 3 months ago

This is a classic "it works on my machine" issue but I seem to be experiencing issues with the files not being found. Would you be able to just rename them to single word files? That seems to work for me. NVM this didn't appear to work. It seems like it was an issue with the window installation of SOX. I was missing the mp3 libraries for it causing it to fail to play. Following the instructions outlined here seemed to fix it.

supercrafter100 commented 3 months ago

Additionally, do we need a way to disable these sounds? In case they get annoying during the performance? Especially because the boxing bell isn't even relevant during the initial conversations?

shiffman commented 3 months ago

Yes, I should have a button for "sounds on" and "off" probably! I'll merge this and work it more in separate branches.

CodingTrain / Bizarro-Devin

Adding Sound Effects #88