search

CodingTrain / Toy-Neural-Network-JS

Neural Network JavaScript library for Coding Train tutorials
MIT License
425 stars 242 forks source link

feedforward() function name #19

Closed shiffman closed 6 years ago

shiffman commented 6 years ago

Would a better name be guess() or inference()? Or is feedforward() good? What is typical?

xxMrPHDxx commented 6 years ago

I would prefer feedforward() cause it define the meaning of the function

musabkilic commented 6 years ago

We use a function called predict() in a python package called Keras. I think predict() is a better name.

shiffman commented 6 years ago

@musabkilic I like predict()!

musabkilic commented 6 years ago

Cool! It seems like the best option for now. Let's see if anybody has a better idea, otherwise I will make a pull request.

shiffman commented 6 years ago

Let's go with predict(). I like the idea of aligning with the Keras API. I can of course make the change but would gladly accept a pull request @musabkilic.

musabkilic commented 6 years ago

Allright. I made a pull request: https://github.com/CodingTrain/Toy-Neural-Network-JS/pull/23

shiffman commented 6 years ago

Closed thanks to #23!