search

CodingTrain / Toy-Neural-Network-JS

Neural Network JavaScript library for Coding Train tutorials
MIT License
425 stars 242 forks source link

Added more transpose tests. #20

Closed mikaelsouza closed 6 years ago

mikaelsouza commented 6 years ago

Not entirely sure if these tests are redundant, however I wanted to test matrices with cols or rows of size 1.

These tests should cover cases in which the there are more cols than rows, more rows than cols and when the matrix have only 1 col and 1 row.

shiffman commented 6 years ago

Apologies I created some merge conflicts by going out of order. Can you resolve?

mikaelsouza commented 6 years ago

Hello!

As this is my first-ish pull request, I don't really know if I solved the conflicts in the right way.

I tried to fix it using github web interface, then I cloned the original updated repo and then I tested it to see if it worked (and it did, but please, someone check it out).

However I would like some recommendations on how to solve merge conflicts properly as it seems too error prone the way I did.

Goodbye!