CodingTrain / thecodingtrain.com

All aboard the Coding Train! Choo choo! 🚂🌈❤️
https://thecodingtrain.com
MIT License
186 stars 105 forks source link

Showcase Page Refinements #945

Open shiffman opened 1 year ago

shiffman commented 1 year ago

Picking up from #501 and #638, here is a list of possible refinements / enhancements for the new Passenger Showcase!

https://thecodingtrain.com/showcase

Individual Passenger Pages

For example: https://thecodingtrain.com/showcase/author/kathy-mcguiness

Showcase Cards

We can use this as a discussion thread and break things out into individual pull requests / issues as needed. Any other thoughts or comments?

kfahn22 commented 1 year ago

RE Name and link to URL. While I like the idea and there might be a one unique URL for an author, that will not always be the case.

Raising a different issue. There are a couple of authors who have contributed under more than one variation of their name and /or contributed a showcase jointly with another person. How do we want to handle this?

shiffman commented 1 year ago

These are very good points!

RE Name and link to URL. While I like the idea and there might be a one unique URL for an author, that will not always be the case.

Yes, since the site is a static build and not database driven what we can do here is quite limited. I think we do our best and just pick the URL from the latest submission for any given author? We can see how that goes and if it doesn't work well, we can try something different.

Raising a different issue. There are a couple of authors who have contributed under more than one variation of their name and /or contributed a showcase jointly with another person. How do we want to handle this?

Different author names will unfortunately show up as different filters/pages with the way the site works. Contributors can go back and edit their names in the JSON files if they want to consolidate the pages. For joint submissions these will end up on their own page since the name is the unique identifier. I'm ok with this for a first try, we can always see if we want to improve the system later!