search

CodingTrain / website-archive

Archive of the Coding Train website (first version)
https://codingtrain.github.io/website-archive/
MIT License
5.72k stars 5.67k forks source link

166 ASCII Image: charIndex out of bounds for white pixels #3633

Open jogerj opened 2 years ago

jogerj commented 2 years ago

in sketch.js, the charIndex of a pixel is calculated as follows: const charIndex = floor(map(avg, 0, 255, 0, len)); Instead, it should be const charIndex = floor(map(avg, 0, 256, 0, len)); because otherwise whites (rgb 255, 255, 255) will be mapped to the exact length of the density string which returns '' (an empty string) instead. This results in tearing on videos. The tricky bit was charAt didn't report any error when accessing out of bound index so it went unnoticed.

Nice tutorial btw

KobeLiesenborgs commented 2 years ago

Hi Jogerj!

Thank you for submitting this errata! You can make a pull request for the fix if you want to! We'll be moving to a new website soon so if this issue is still open when we move I'll add the fix myself!