CodingZeal / create-react-app

Create React apps with no build configuration.
MIT License
2 stars 2 forks source link

Add eslint-config-zeal and friends #9

Closed randycoulman closed 7 years ago

randycoulman commented 7 years ago

Use eslint-config-zeal and its peer dependencies instead of eslint-config-react-app. That way, all of our lint error/warning reports are consistent.

To allow client projects to customize the eslint configuration locally, we comment out the local config that CRA uses normally. That way, eslint will keep searching up into the host project to find an eslint config file, which is what we want in our apps.

We add a lint script to allow the client project to be able to run our version of eslint and its plugins against the application’s source files.

I chose not to address the code in the eject script that works with the local eslint config file as I don't think we don't expect people to eject from our CRA fork. If I'm wrong about that, I'll revisit this decision.