search

Codisimus / PhatLoots

Bukkit Plugin which provides highly configurable loot for all
http://codisimus.com/phatloots
18 stars 58 forks source link

Continuing PhatLoots Officially #105

Open Redned235 opened 5 years ago

Redned235 commented 5 years ago

Was brought by the attention of @PikaMug that you recently popped back on GitHub. I also noticed that you starred my repo :).

Basically, I've been using this plugin for a little over a year now after obtaining a server using it. After updating to 1.13, I noticed you no longer updated it and the plugin struggled to work properly on the current version. I decided to update it and publicly submit my changes on GitHub, and have been asked by multiple people to submit a build on Bukkit or Spigot.

Considering you are the author and this is your work, I decided not to. So I guess what I'm asking is if I can officially take over the development for PhatLoots and submit my new version on either Bukkit or Spigot.

Thanks for reading. Redned

PikaMug commented 5 years ago

This project’s legacy as the de facto standard for chest loots has not been forgotten. The Minecraft server community would greatly benefit from it’s revival and it’s my opinion that Redned is the most qualified fork maintainer to facilitate its return. +1

finder1793 commented 5 years ago

I definitely endorse this. been using redneds fork for quite a while now.

briannastatic commented 5 years ago

I totally vouch for Redned hes a great developer :)

Codisimus commented 5 years ago

I am encouraged that you are interested in continuing this project. I am looking through a few forks and will be choosing someone to take control of the plugin moving forward. This is something that I should've done years ago but I guess I always thought I'd come back to it.

I haven't made a decision yet but the support I see here is promising.

Redned235 commented 5 years ago

I am encouraged that you are interested in continuing this project. I am looking through a few forks and will be choosing someone to take control of the plugin moving forward. This is something that I should've done years ago but I guess I always thought I'd come back to it.

I haven't made a decision yet but the support I see here is promising.

If you do choose me to continue this plugin, I will always accept code contributions and plan on supporting it for years to come. Since this is your codebase, the decision is truly yours and I respect that.

Once again, thank you for replying here and opening the door for this plugin to be continued! I really appreciate it.

Maitlans commented 5 years ago

I hope @RednedEpic is chosen, hes been very helpful and seems like he cares for the plugin. As well as the plugin is supported by Quests which is another reason why I got it and needs to be continued as it's a great asset to the community :D

kohlth commented 5 years ago

Hello im a community member on redneds server and as a long time player and now current staff member on it, can at least i promise he will at the very least keep this plugin up to date and possibly improve upon it

Redned235 commented 5 years ago

Just checking back here after a little while. I'm very much motivated to continue this project going forward and definitely have big plans for it. Once a final decision has been made, please let me know.

Thanks.

Jorack10 commented 5 years ago

Is there any 1.14 support available at all? it would be very helpful!

Redned235 commented 5 years ago

Is there any 1.14 support available at all? it would be very helpful!

My current fork supports 1.14 as of just a few days ago. Please reach out to me on Discord at Redned#9473 for more information.

Jorack10 commented 5 years ago

I just wanted to comment, letting you guys know Redned was quick to respond and provided personal help quickly. If this mod was revived Redned would be a great candidate.

jeannen commented 5 years ago

I don't know him but I approve him too, that would be amazing if PhatLoots could be brought back to life

jeannen commented 5 years ago

Redned#9473

I added you on Discord ^^

briannastatic commented 5 years ago

Another thought @RednedEpic why don’t you just submit a pull request? You get to support the project and keep it updated and don’t have move people to a new repository.

Redned235 commented 5 years ago

Another thought @RednedEpic why don’t you just submit a pull request? You get to support the project and keep it updated and don’t have move people to a new repository.

I'd seen from multiple people that they tried to contact Codisimus, and were unsuccessful. So I really didn't feel like a PR would do much.

However, since he's responded to this issue here, I think it'd be better to just wait for a decision to be made as he said he'd be choosing someone to continue the plugin. So unless he decides he wants to continue the plugin himself, I don't think a PR would be necessary.

briannastatic commented 5 years ago

It's still not fully operational but not very far from it, with a small community of issue and enhancement reporters it should be quite the project. In contrary to using YAML as a phatloots config it uses JSON the downside being it isn't compatible with PhatLoots directly, but the upside being you don't need to be a wizard at the whole yaml serialization system.

I'm not at all sure what this has to do with the OP's issue. It seems you're using this @RednedEpic's issue as opportunity to advertise your project 🤦‍♀

Redned235 commented 5 years ago

The main problem I just had with the project is that the development of the project using YAML serialization puts me off. I did update it to 1.13 to make it work. And 4 posts later Codismus said he will look at the forks and choose one, since this isn't a direct fork of PhatLoots that's why I'm posting it.

A bit off topic but...

I’ve taken a look at your project and it definitely looks neat, however the majority of people in the Bukkit community prefer YAML over JSON from what I can see. Plus as a long time user of PhatLoots (over 6 years), in my opinion, I think it’d be better to just continue with the original codebase considering I have almost 400 different loot tables (and others may too).

If people start mentioning they’d prefer YML over JSON, then that might be the direction to go. But unless people have complained about the existing configuration system, I don’t see a reason to completely swap over to JSON.

PikaMug commented 5 years ago

@Articdive Your project states in its description that it's a "recreation" of PhatLoots. This ticket is about "continuing" the PhatLoots project; not deprecating it in favor of similar one with a different name and package structure. I'm also trusting that you wrote most of your project's classes yourself, otherwise there could be an issue with having applied a license to code which you don't own (IANAL).

That said, I don't see any reason why a fork couldn't be updated to use both YAML and JSON.

jeannen commented 5 years ago

Yeah, YAML is way more user-friendly than JSON imo

Codisimus commented 5 years ago

I have looked through several forks/commits and have decided to promote RednedEpic's continuation of this project. I will hand over whatever is needed and do what I can to transition the project into more capable hands. I plan to update documentation to point people away from this stale repo. Any questions I receive will be redirected to RednedEpic. I encourage others to contribute as well, either to RednedEpic's project or to your own fork. There is nothing wrong with going a different direction to offer server admins something new. I however, will be recommending RednedEpic's fork and contributing to it if I do ever find the time to get back into plugin development. Thank you to everyone for your continued interest in PhatLoots.

Redned235 commented 5 years ago

I have looked through several forks/commits and have decided to promote RednedEpic's continuation of this project. I will hand over whatever is needed and do what I can to transition the project into more capable hands. I plan to update documentation to point people away from this stale repo. Any questions I receive will be redirected to RednedEpic. I encourage others to contribute as well, either to RednedEpic's project or to your own fork. There is nothing wrong with going a different direction to offer server admins something new. I however, will be recommending RednedEpic's fork and contributing to it if I do ever find the time to get back into plugin development. Thank you to everyone for your continued interest in PhatLoots.

Thank you very much for allowing me to continue this amazing plugin! As of right now I don't feel like I need anything from you specifically but please feel free to reach out to me on Discord at Redned#9743 or on Spigot (https://www.spigotmc.org/members/redned.188162/) if you would like to discuss more.

LastTulare commented 4 years ago

Im glad I found this! I used Phatloots back 5 years ago on 1.7.8. Coming back after 5 years its been a struggle to set up seeing so many of the good plugin projects ended. Thank you Codisimus and Redned for keeping this alive