search

Codit / practical-api-guidelines

Practical guidelines for building & designing APIs with .NET.
MIT License
16 stars 5 forks source link

fixing build error #115

Closed pietersap closed 5 years ago

pietersap commented 5 years ago

I had made a small error while resolving conflicts in the Github UI. After pulling master, it wouldn't build due to a non-implemented interface member. The project should build and run smoothly now. Also renamed carControllerTest.cs to CarControllerTest.cs

tomkerkhove commented 5 years ago

That's interesting. Is it because you didn't wait for the CI to finish or did the CI not cover it?

pietersap commented 5 years ago

That's interesting. Is it because you didn't wait for the CI to finish or did the CI not cover it?

I'm not sure how much time the CI should usually take, but I did resolve the conflicts a little before the PR's became approved and merged (all happened within 20 min)

tomkerkhove commented 5 years ago

@pietersap What PR was this?