Codit / practical-api-guidelines

Practical guidelines for building & designing APIs with .NET.
MIT License
16 stars 5 forks source link

CI should build with release configuration #123

Closed tomkerkhove closed 5 years ago

tomkerkhove commented 5 years ago

CI should build with release configuration.

Relates to #108

tomkerkhove commented 5 years ago

/azp run ci

azure-pipelines[bot] commented 5 years ago

Azure Pipelines successfully started running 1 pipeline(s).

tomkerkhove commented 5 years ago

We're not there yet but will tackle it next week, is that ok @fgheysels ?

fgheysels commented 5 years ago

Created PR #124 that should fix the build. Is there a possibility to run the build and tests before the PR can be closed / merged ?

tomkerkhove commented 5 years ago

@fgheysels Certainly there is, but the automatic trigger is broken for now. Working on that!

You can run /azp run ci which triggers it manually.

Sorry for the sloppy transition :(

tomkerkhove commented 5 years ago

/azp run ci

azure-pipelines[bot] commented 5 years ago

Azure Pipelines successfully started running 1 pipeline(s).

tomkerkhove commented 5 years ago

That fixed it, thanks @fgheysels 🎉