Fix api version in uri path

tomkerkhove commented 6 years ago

tomkerkhove commented 6 years ago

I'm not aware of what {version:apiVersion} & Microsoft.AspNetCore.Mvc.Versioning leverage so might be my ignorance - If so, sorry and ignore below

@MassimoC @samneirinck is this intentionally that you can specify version when calling the endpoint instead of having fixed versions in the routes?

My suggestion would be to:

Use Controllers\v1\PlayersController.cs as a folder structure
Use world-cup/v1/[controller] as route on controller

This would mean that the version is explicit and we only generate URLs for supported endpoints as well. Now the user needs to know what versions are supported or am I missing something?

MassimoC commented 5 years ago

@MisterKite actually versioning as a parameter is pretty annoying. Please apply the suggestion of Tom

MassimoC commented 5 years ago

closed with the PR #50

Codit / practical-api-guidelines

Fix api version in uri path #20