fix: update to handle missing git_provider

[danstis]

User description

Related to Issue #993

---

PR Type

Bug fix, Enhancement

---

Description

• Added error handling for missing git_provider attribute in the configuration file, raising a ValueError with a clear message.
• Reformatted long lines to improve code readability and maintainability.
• Enhanced the context checking logic to ensure git_provider and pr_url are properly validated before use.

---

Changes walkthrough 📝

	Relevant files
Enhancement	__init__.py Handle missing `git_provider` attribute and improve code readability pr_agent/git_providers/__init__.py Added handling for missing git_provider attribute in configuration. Improved readability by reformatting long lines. Enhanced context checking logic for git_provider. +16/-10

---

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro[bot]]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🏅 Score	85
🧪 Relevant tests	No
🔒 Security concerns	No
🔀 Multiple PR themes	No
⚡ Key issues to review	Possible Bug: Ensure that the error handling for missing git_provider is tested to confirm that the correct exception is raised with the expected message.
	Code Clarity: The reformatting of the dictionary _GIT_PROVIDERS and the conditional checks in get_git_provider_with_context function improve readability but ensure consistency in using quotes (single vs double) across the project.

[codiumai-pr-agent-pro[bot]]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Log a warning message before raising an error for unknown git providers ___ **Consider logging a warning message before raising a ValueError for an unknown git provider to aid in debugging and provide more context in logs.** [pr_agent/git_providers/__init__.py [32-33]](https://github.com/Codium-ai/pr-agent/pull/994/files#diff-91af7b74c12181fd8aac8cd7ec8af9a01aed1adfb67eff4748e8f6a6ca3cc660R32-R33) ```diff if provider_id not in _GIT_PROVIDERS: + logger.warning(f"Attempted to use unknown git provider: {provider_id}") raise ValueError(f"Unknown git provider: {provider_id}") ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7 Why: Adding a logging statement before raising an exception is a good practice for debugging and operational monitoring, making this a valuable suggestion.	7
	Simplify nested if conditions into a single line for better readability ___ **Simplify the nested if conditions by combining them into a single line to improve readability and reduce code complexity.** [pr_agent/git_providers/__init__.py [49-53]](https://github.com/Codium-ai/pr-agent/pull/994/files#diff-91af7b74c12181fd8aac8cd7ec8af9a01aed1adfb67eff4748e8f6a6ca3cc660R49-R53) ```diff -if ( - is_context_env - and context.get("git_provider") - and context.get("git_provider").get("pr_url") -): +if is_context_env and context.get("git_provider") and context["git_provider"].get("pr_url"): ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 6 Why: The suggestion to simplify the nested `if` conditions is valid and improves readability, although it's a minor enhancement.	6

[mrT23]

thanks for the feedback was solved by this: https://github.com/Codium-ai/pr-agent/commit/3f3e9909fe972f8f75e12d4bb8c49e8ee887e219

[danstis]

Awesome, closing this one.