search

Codoc-os / django-opensearch-dsl

This is a package that allows indexing of django models in opensearch with opensearch-py.
Other
24 stars 16 forks source link

fix: add compatibility for update on polymorphic models #34

Closed VicenteMerino closed 1 year ago

VicenteMerino commented 1 year ago

This handles the case when trying to declare a document of a polymorphic model, like the ones defined in the django-polymorphic library.

More details are specified on #35

codecov-commenter commented 1 year ago

Codecov Report

Merging #34 (3d33b34) into master (fb15fc9) will decrease coverage by 0.21%. The diff coverage is 20.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   95.86%   95.65%   -0.21%     
==========================================
  Files           9       12       +3     
  Lines         435      576     +141     
  Branches       63       80      +17     
==========================================
+ Hits          417      551     +134     
- Misses         17       21       +4     
- Partials        1        4       +3
Impacted Files Coverage Δ
django_opensearch_dsl/registries.py 94.93% <20.00%> (-5.07%) :arrow_down:

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

qcoumes commented 1 year ago

Thanks for you contribution @VicenteMerino, this fix will be in the next release