search

CodyEngel / fakek

A faker library for Kotlin.
Apache License 2.0
7 stars 5 forks source link

Add Fake Commerce #19

Closed CodyEngel closed 4 years ago

CodyEngel commented 4 years ago

Add commerce, this should include color, department, material, price, productName, and promotionCode.

Note: does commerce make sense or would product be a better name for this?

RafaelPereiraSantos commented 4 years ago

Hi @CodyEngel may I take part in this?

Looking at the idea of "commerce" I agre its seems in fact that it is a product, commerce should be other instance that contains this "product" or maybe "sells" it

CodyEngel commented 4 years ago

@RafaelPereiraSantos would it make sense to have commerce be the combination of several other fakes? I think commerce could almost contain fake data from Fake Company (#18), Fake Address, and then Fake Product which could maybe be a list of products that the company sells?

RafaelPereiraSantos commented 4 years ago

@CodyEngel this sounds even better

After seeing this new idea I think commerce could be a kind of subtype of company (with products, addresses and so on) or an aggregation of these fake data you mentioned (fake: companies, products, addresses).

either way, I agree commerce should not be the product itself

what about it?

CodyEngel commented 4 years ago

Making commerce a sub-type of company makes sense to me @RafaelPereiraSantos. We'd want to leverage the information already present with company while also including the products and address.

RafaelPereiraSantos commented 4 years ago

Great! we could star by implementing a fake for companies and them come back to this issue to create the subtype ``commerce``` with products and addresses, @CodyEngel

If you agree I, would be gladly to start and take the issue #18, could you assign me ?

CodyEngel commented 4 years ago

@RafaelPereiraSantos yeah go ahead and pick up #18 -- I'm going to work on contributor roles over the next day or so. In the meantime if you could comment on #18 that should allow me to assign it to you.

RafaelPereiraSantos commented 4 years ago

hey @CodyEngel I saw that you merged my pr related to the issue #18 so I think we can start this one, what do you think? is there any point we need to discuss? other wise, if you could assign me, I can start it.

CodyEngel commented 4 years ago

This is good to pick up @RafaelPereiraSantos, will go ahead and assign it to you. Thank you!