CodyEngel / fakek

A faker library for Kotlin.

Apache License 2.0

7 stars 5 forks source link

Add Fake hex color functionality #20

Closed RafaelPereiraSantos closed 4 years ago

RafaelPereiraSantos commented 4 years ago

17 Add Fake Hex Color

Added a FakeColor hexadecimal value with and without the hash symbol

RafaelPereiraSantos commented 4 years ago

@CodyEngel here it its, do you have any suggestion?

CodyEngel commented 4 years ago

Hey @RafaelPereiraSantos the changes look good to me, only changes I could see are more stylistic ones. In the unit test for FakeColor I'd move the function before the tests that use it, and the mock for FakeColor may not require the also. The documentation looks good though, and I also really liked the idea of having an option to exclude the hex symbol.

I'll work on creating PR templates and setting up a style guide so it's easier for future contributors but this PR looks good to me.

RafaelPereiraSantos commented 4 years ago

Thanks for the feedback @CodyEngel, I'm sure I can commit these changes before you merge it, since it is pretty simple I will do it right away.

It is a great idea to have a pr template and style guide! I'm looking forward to contribute with this lib in the future, I really enjoy using the Faker in projects I work on in Ruby and I think would be great to have it available in pure Kotlin as well.

CodyEngel commented 4 years ago

Awesome, the changes look good to me @RafaelPereiraSantos, I'll go ahead and merge this.