CodyEngel / fakek

A faker library for Kotlin.
Apache License 2.0
7 stars 6 forks source link

Feature/fake company #31

Closed RafaelPereiraSantos closed 3 years ago

RafaelPereiraSantos commented 3 years ago

Closes #18

Description

This PR intend to create the wrapper of fake companies

Technical Details

Adding a class wrapper of fake companies called FakeCompany with all the fields requested in the issue #18 all fields but the url are from the original fake lib, the url field is retrieved from the already existent FakeUrl class

Code Samples

Please provide code samples for how these changes will be used by applications consuming this library. Here's an example:

fun main() {
    val fakeCompany = fakek.fakeCompany
    print(" ${fakeCompany.name} is a company of the sector ${fakeCompany.profession} with headquarters in US")
}

Reviewers: @CodyEngel

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2f5cf6b). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage        ?   98.38%           
  Complexity      ?       47           
=======================================
  Files           ?       12           
  Lines           ?      124           
  Branches        ?        4           
=======================================
  Hits            ?      122           
  Misses          ?        0           
  Partials        ?        2           
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/dev/fakek/FakeContext.kt 100.00% <100.00%> (ø) 1.00 <0.00> (?)
src/main/kotlin/dev/fakek/fakes/FakeCompany.kt 100.00% <100.00%> (ø) 11.00 <11.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5cf6b...89f6bc7. Read the comment docs.

CodyEngel commented 3 years ago

Whoops, @RafaelPereiraSantos it looks like there are some conflicts on FakeContextTest, can you tag me once those are resolved? After that this should be good to merge in.

RafaelPereiraSantos commented 3 years ago

@CodyEngel Everthing seems ok now, could you merge it?

CodyEngel commented 3 years ago

Merged, thanks for your contribution @RafaelPereiraSantos.