CodyEngel / fakek

A faker library for Kotlin.
Apache License 2.0
7 stars 6 forks source link

fake artist support #33

Closed pedro-cze closed 3 years ago

pedro-cze commented 3 years ago

Closes #14

Description

Added support for artist, that includes a name.

Technical Details

The implementation consists of following pieces:

Code Samples

fun main() {
    val fakeArtist: FakeArtist(name = "John Doe")
    fakek { println("fakeArtist: $fakeArtist") }
}

Reviewers: @CodyEngel

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 into main will increase coverage by 0.46%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #33      +/-   ##
============================================
+ Coverage     97.93%   98.40%   +0.46%     
- Complexity       34       46      +12     
============================================
  Files            10       13       +3     
  Lines            97      125      +28     
  Branches          4        3       -1     
============================================
+ Hits             95      123      +28     
- Misses            0        1       +1     
+ Partials          2        1       -1     
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/dev/fakek/FakeContext.kt 95.83% <100.00%> (-4.17%) 1.00 <0.00> (ø)
src/main/kotlin/dev/fakek/fakes/FakeAncient.kt 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/main/kotlin/dev/fakek/fakes/FakeArtist.kt 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/kotlin/dev/fakek/fakes/FakeBoolean.kt 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/main/kotlin/dev/fakek/fakes/FakeCreditCard.kt 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
src/main/kotlin/dev/fakek/fakes/FakePassword.kt 85.71% <0.00%> (+19.04%) 3.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82b9b36...24c3dd6. Read the comment docs.

pedro-cze commented 3 years ago

np @CodyEngel, thank you too.