Closed Nowele closed 3 years ago
Converted to draft since I haven't been assigned the issue yet, feel free to close if it was assigned to someone else :)
Merging #49 into main will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 99.11% 99.11%
Complexity 95 95
=========================================
Files 21 21
Lines 225 226 +1
Branches 3 3
=========================================
+ Hits 223 224 +1
Misses 1 1
Partials 1 1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/main/kotlin/dev/fakek/FakeContext.kt | 97.43% <100.00%> (ø) |
1.00 <0.00> (ø) |
|
src/main/kotlin/dev/fakek/fakes/FakeSSN.kt | 100.00% <100.00%> (ø) |
5.00 <5.00> (?) |
|
src/main/kotlin/dev/fakek/fakes/FakeAviation.kt |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 46921ce...1595bac. Read the comment docs.
Hey @Nowele assigned this to you, the initial changes look good. I was hoping to include valid
and invalid
options for SSN, it looks like you have valid
could you add invalid
as well? After that the changes should be good to merge. Thank you :)
Hey @Nowele assigned this to you, the initial changes look good. I was hoping to include
valid
andinvalid
options for SSN, it looks like you havevalid
could you addinvalid
as well? After that the changes should be good to merge. Thank you :)
Apologies for the delay! I've resolved conflicts and addressed your feedback.
Closes #45
Description
Creation of FakeSSN as a wrapper for IdNumber that returns a valid SSN.
Technical Details
Code Samples
Please provide code samples for how these changes will be used by applications consuming this library. Here's an example:
Reviewers: @CodyEngel