Closed mattkimmel closed 4 years ago
Hey @mattkimmel the changes are looking good although there are merge conflicts. Can you resolve those and tag me once they are resolved? From there I can review and merge these changes, thank you!
Hi @CodyEngel -- I just resolved the merge conflicts. Let me know if there's anything else I can do for this PR!
Actually @mattkimmel -- it looks like Circle CI is a little confused. Can you close and re-open this PR? That should kick of a fresh build. I'd also recommend running ./gradlew detekt
prior to doing this, it looks like some files don't have a new line at the end of file which will fail on the run_detekt
step.
Closes #36
Description
Creates a FakeBeer class that wraps a corresponding fake in java-faker, to provide all the fake beer your code can drink.
Technical Details
fakeBeer
toFakeContext
.FakeBeer
class to contain values obtained fromjava-faker
.FakerBeer
alias toFakerTypeAliases
.FakerContextTest
forfakeBeer
.FakeBeerTest
test class to testFakeBeer
.Code Samples
Reviewers: @CodyEngel