CodyEngel / fakek

A faker library for Kotlin.
Apache License 2.0
7 stars 5 forks source link

Enhancement / Add FakeBeer #50

Closed mattkimmel closed 4 years ago

mattkimmel commented 4 years ago

Closes #36

Description

Creates a FakeBeer class that wraps a corresponding fake in java-faker, to provide all the fake beer your code can drink.

Technical Details

Code Samples

fun main() {
    // fakeBeer: FakeBeer(name=Koors, style=Lager, hop=Cashmere, malt=Caramel, yeast=Pilsen)
    fakek { println("fakeBeer: $fakeBeer") }
}

Reviewers: @CodyEngel

CodyEngel commented 4 years ago

Hey @mattkimmel the changes are looking good although there are merge conflicts. Can you resolve those and tag me once they are resolved? From there I can review and merge these changes, thank you!

mattkimmel commented 4 years ago

Hi @CodyEngel -- I just resolved the merge conflicts. Let me know if there's anything else I can do for this PR!

CodyEngel commented 4 years ago

Actually @mattkimmel -- it looks like Circle CI is a little confused. Can you close and re-open this PR? That should kick of a fresh build. I'd also recommend running ./gradlew detekt prior to doing this, it looks like some files don't have a new line at the end of file which will fail on the run_detekt step.