CodyEngel / fakek

A faker library for Kotlin.
Apache License 2.0
7 stars 6 forks source link

Enhancement/fake app #54

Closed Caps-Looking closed 3 years ago

Caps-Looking commented 3 years ago

Closes #12

Description

Creation of a wrapper of fake apps.

Technical Details

Code Samples

Please provide code samples for how these changes will be used by applications consuming this library. Here's an example:

fun main() {
    val semanticVersion = SemanticVersion()
    semanticVersion.changePatch(2)
    val fakeApp: FakeApp(name="Treeflex", version="1.85", author="Daphne Swift", semanticVersion=semanticVersion)
    fakek { println("App: Name - ${fakeApp.name}, Version - ${fakeApp.version}, Author - ${fakeApp.author}, Semantic Version - ${fakeApp.semanticVersion}") }
}

IDK if that's what you thought about architecture to create the semantic version, or if these are the right parameters. Let me know what you think about it and your suggestions.

Reviewers: @CodyEngel

CodyEngel commented 3 years ago

Hey @Caps-Looking -- tests are currently failing on CI. Once those are resolved I can go ahead and review & merge the changes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #54 (c05e960) into main (7d84f12) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #54      +/-   ##
============================================
+ Coverage     99.21%   99.27%   +0.06%     
- Complexity      109      121      +12     
============================================
  Files            24       26       +2     
  Lines           254      275      +21     
  Branches          3        3              
============================================
+ Hits            252      273      +21     
  Misses            1        1              
  Partials          1        1              
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/dev/fakek/FakeContext.kt 97.87% <100.00%> (+0.09%) 1.00 <0.00> (ø)
src/main/kotlin/dev/fakek/fakes/FakeApp.kt 100.00% <100.00%> (ø) 6.00 <6.00> (?)
...main/kotlin/dev/fakek/fakes/FakeSemanticVersion.kt 100.00% <100.00%> (ø) 6.00 <6.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d84f12...c05e960. Read the comment docs.

Caps-Looking commented 3 years ago

Hi @CodyEngel!

Sorry for the delay, got covid and my life is been crazy since then. I just merged with main, and it seems everything is working now.

CodyEngel commented 3 years ago

Whoa @Caps-Looking welcome back! Sorry about my late response back, life has been hectic at work. Really sorry to hear that you got covid but I'm happy to see you are doing better. I'll go ahead and get this merged in 💪