search

CodySchrank / gSwitch

macOS menu bar app that allows control over the gpu on dual gpu macbooks
MIT License
887 stars 46 forks source link

Started French and German localizations of main menu #24

Closed HackintoshHD closed 6 years ago

HackintoshHD commented 6 years ago

Started French and German localizations of gSwitch by translating the main menu's strings

HackintoshHD commented 6 years ago

As proposed in enhancement issue #22, I've started French and German localizations for gSwitch by translating the main menu. Feel free to edit and/or merge the commit, if it's already in the appropriate format, or to simply close it, if it isn't.

CodySchrank commented 6 years ago

Awesome! I will confirm it this weekend.

CodySchrank commented 6 years ago

Looks good! Any chance you could do the preferences window too? If not thats ok I will merge the current translations. Don't worry about the advanced window or help window.

HackintoshHD commented 6 years ago

Thanks for your review of the PR's code, I'm glad it's okay and l'll continue on the remaining UI parts then. I've started working on the preferences and advanced windows and will hopefully be able to commit the results this weekend.

CodySchrank commented 6 years ago

You don’t have to do the advanced window I imagine it will get limited use.

HackintoshHD commented 6 years ago

I've now localized the Preferences windows to both French and German and pushed the results as commit 49f6149. Since I already had begun localizing the Advanced window, too, I had to subsequently edit out all references to its (uncommited) resources from project.pbxproj in commit fdd38f6 and 9116923.

I hope I didn't miss anything and that you can use the results.

CodySchrank commented 6 years ago

Awesome! Thanks for the translations. Everything looks good so they should be in the next release.