JES file naming convention for Run3 breaks FactorizedJetCorrector

CoffeaTeam / coffea

Basic tools and wrappers for enabling not-too-alien syntax when running columnar Collider HEP analysis.

https://coffeateam.github.io/coffea/

BSD 3-Clause "New" or "Revised" License

128 stars 126 forks source link

JES file naming convention for Run3 breaks FactorizedJetCorrector #1111

Open valsdav opened 2 months ago

valsdav commented 2 months ago

https://github.com/CoffeaTeam/coffea/blob/f7e9119ba4567ba6a5e593da77627af475eae8e9/coffea/jetmet_tools/FactorizedJetCorrector.py#L75

Summer22EE_22Sep2023_RunF_V2_DATA_L1FastJet_AK4PFPuppi.txt.gz

____^
Summer22EE_22Sep2023_RunF_V2_DATA_L2Relative_AK4PFPuppi.txt.gz
Summer22EE_22Sep2023_RunF_V2_DATA_L2L3Residual_AK4PFPuppi.txt.gz

The additional underscore breaks the naming convention. Do you recommend just renaming the files of patching the module?

lgray commented 2 months ago

For now, I would just change a _ to a -. This will be better fixed with the correctionlib implementation that Andrea Piccinelli will be working on for the CorrectedJetsFactory.