JECs need validation against the official implementation

CoffeaTeam / coffea

Basic tools and wrappers for enabling not-too-alien syntax when running columnar Collider HEP analysis.

https://coffeateam.github.io/coffea/

BSD 3-Clause "New" or "Revised" License

133 stars 127 forks source link

JECs need validation against the official implementation #15

Closed lgray closed 3 years ago

lgray commented 5 years ago

Validate our JEC implementation against: https://twiki.cern.ch/twiki/bin/viewauth/CMS/JERCReference

jpata commented 5 years ago

I wanted to mention here that I cross-checked the results from the JEC (nominal correction, no uncertainties yet) in detail against the JetRecalibrator in nanoaod-tools and got perfect closure!

However, I did notice a small feature in coffea that may lead to unintented consequences:

FactorizedJetCorrector.getCorrection(JetPt=raw_pt, ...)

will modify the original raw_pt vector in place!

lgray commented 5 years ago

@jpata ahh nice bug. I'll patch it up in a bit.

lgray commented 3 years ago

Fixed by @aperloff in #483