search

CoffeaTeam / fsspec-xrootd

An XRootD implementation for fsspec
https://coffeateam.github.io/fsspec-xrootd/
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

feat: support `simplecache` url chaining #42

Closed lobis closed 11 months ago

lobis commented 11 months ago

related to https://github.com/scikit-hep/uproot5/pull/1075.

I would like to add a test in uproot where we test the simplecache but the files I know of are too big, would it be possible to have a small test file hosted over xrootd so we can test it? (file would need to be downloaded whole).

Edit: At the end I ended up adding an xrootd server fixture to uproot so we can test this on local files, so no need to add a new small file, but I don't think it'll hurt to add one in any case.

lobis commented 11 months ago

After merging this PR a release would be needed in order to merge https://github.com/scikit-hep/uproot5/pull/1075.

nsmith- commented 11 months ago

Will this close #42 ?

lobis commented 11 months ago

Will this close #42 ?

Closes https://github.com/CoffeaTeam/fsspec-xrootd/issues/41

nsmith- commented 11 months ago

Go ahead and merge, also feel free to make a release