search

CoffeaTeam / fsspec-xrootd

An XRootD implementation for fsspec
https://coffeateam.github.io/fsspec-xrootd/
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Paths drop parameters in unstrip_protocol #64

Closed nsmith- closed 2 weeks ago

nsmith- commented 1 month ago

Symptom:

import fsspec

url = "root://eospublic.cern.ch//eos/root-eos/benchmark/Run2012B_SingleMu.root?blah=blah"
fs, path = fsspec.core.url_to_fs(url)
print(fs, path)

returns

<fsspec_xrootd.xrootd.XRootDFileSystem object at 0x10ad0d040> /eos/root-eos/benchmark/Run2012B_SingleMu.root

the second argument should be /eos/root-eos/benchmark/Run2012B_SingleMu.root?blah=blah, but the parameters are dropped.

The issue is that we are using XRootD.client.URL.path when we should be using path_with_params in https://github.com/CoffeaTeam/fsspec-xrootd/blob/784540ce92f5b0bf3978a1410a70975f8838f3d2/src/fsspec_xrootd/xrootd.py#L305