search

Coffee-fueled-deadlines / OSRSBytes

OSRSBytes is an all-in-one Python library for Old School Runescape (OSRS) that features Item Information Lookup, OSRS Hiscores, and Grand Exchange Market information.
Eclipse Public License 2.0
49 stars 13 forks source link

Fix Indentation issues #33

Closed lordsherman closed 1 year ago

lordsherman commented 1 year ago

This Indentation issue appears to be causing the inability to use the update function on the Items class. There was also a small typo in the items invocation example.

There was a mix of spaces and tabs. The main file seems to use tabs exclusively so I have removed all the spaces.

Coffee-fueled-deadlines commented 1 year ago

Thank you for the work put into it, a few notes:

  1. While the majority of the file does, in fact, use tabs: pep standard actually prefers and leans towards spaces. This is a planned fix in the 1.3.1 version.
  2. Changes made to the package should be pushed to dev, not to master.
Coffee-fueled-deadlines commented 1 year ago

If you fetch dev, you'll note that I've just converted all tabs to spaces. You're free to merge in the missing ) on the readme file though.