search

Coffee-fueled-deadlines / OSRSBytes

OSRSBytes is an all-in-one Python library for Old School Runescape (OSRS) that features Item Information Lookup, OSRS Hiscores, and Grand Exchange Market information.
Eclipse Public License 2.0
49 stars 13 forks source link

Items.update() missing from latest PyPI build #37

Closed jakewalker-codes closed 1 year ago

jakewalker-codes commented 1 year ago

Hi

The Items() class is missing the update() method in the

image

I had a look at the OSRSBytes library thats installed in my virtual environment and it's missing the update method:

image

The Items.py file in the main and dev branch all have this method though and adding the snippet from the repo to the Items.py file in my virtual environment fixed this issue.

I installed the OSRSBytes library by running the pip install command

upgrading, uninstalling and reinstalling using pip did not fix the issue

I am running version 1.3.0 of OSRSBytes

Thanks,

Coffee-fueled-deadlines commented 1 year ago

Correct. I believe at some point Dev got merged into Master unintentionally. Update() will be added in the 1.3.1 release. In addition, an easy work around would be to just initialize Items() again as such:

i = Items()

# do some stuff
i.isMembers("rune dagger")

# update items again
i = Items()
jakewalker-codes commented 1 year ago

Thanks for your speedy response! :)

Coffee-fueled-deadlines commented 1 year ago

Not a problem, thank you for the report.