search

Coffee-fueled-deadlines / OSRSBytes

OSRSBytes is an all-in-one Python library for Old School Runescape (OSRS) that features Item Information Lookup, OSRS Hiscores, and Grand Exchange Market information.
Eclipse Public License 2.0
49 stars 13 forks source link

hiscores indexing issues: #38

Closed johnnydhnguyen closed 1 year ago

johnnydhnguyen commented 1 year ago

I've noticed that whilst running a for through each boss name in the dictionary provided in the code, everything after obor shifts one index to the right.

After debugging, I found that this may be due to the phantom muspah update has caused an issue in indexing when calling onto the osrs hiscores api.

Coffee-fueled-deadlines commented 1 year ago

I've noticed that whilst running a for through each boss name in the dictionary provided in the code, everything after obor shifts one index to the right.

After debugging, I found that this may be due to the phantom muspah update has caused an issue in indexing when calling onto the osrs hiscores api.

Thank you for pointing this out. I had a feeling that this would be something that would, honestly, come to be common-place due to jagex's janky excuse for a hiscores page.

I'll push out a fix this weekend.

johnnydhnguyen commented 1 year ago

I fixed the issue on my end, what you can do is to go into hiscores.py

right under "obor" in the parseBosses function, add in "phantom_muspah". Should fix the issue instantly.

Coffee-fueled-deadlines commented 1 year ago

Fixed as of this commit.